Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing web-token/jwt-framework dependency to magento/module-jwt-framework-adapter #32612

Merged
merged 1 commit into from
Apr 11, 2021
Merged

Added missing web-token/jwt-framework dependency to magento/module-jwt-framework-adapter #32612

merged 1 commit into from
Apr 11, 2021

Conversation

bgorski
Copy link
Contributor

@bgorski bgorski commented Mar 28, 2021 •
edited
Loading

Description (*)

The Magento_JwtFrameworkAdapter module introduces a new dependency on the web-token/jwt-framework package. The dependency is added to the product-level (global) composer.json file, but it's missing from the module itself. This PR addresses that and adds it.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Missing dependency in Magento/JwtFrameworkAdapter #32578

Manual testing scenarios (*)

This is only about adding a dependency on module level that already exists on product level - no tests are required, only a reproduction of the issue linked above.
As a reference, check Magento_AwsS3 module's composer.json - notice that all its "league" dependencies are both there and in the global composer.json

Questions or comments

The missing dependency needs to be in both global and module-level composer.json or else installations pulled from github wouldn't install it.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 28, 2021

Hi @bgorski. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added the Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. label Mar 28, 2021
@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Mar 28, 2021
@bgorski
Copy link
Contributor Author

bgorski commented Mar 28, 2021

@magento run all tests

@ihor-sviziev ihor-sviziev self-assigned this Mar 29, 2021
@m2-community-project m2-community-project bot moved this from Pending Review to Review in Progress in Pull Requests Dashboard Mar 29, 2021
@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests CE, Integration Tests

@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Mar 29, 2021
ihor-sviziev
ihor-sviziev approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔ Approved.

Failing tests looks not related to changes from this PR.

@m2-community-project m2-community-project bot moved this from Review in Progress to Ready for Testing in Pull Requests Dashboard Mar 29, 2021
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8974 has been created to process this Pull Request

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests CE, Integration Tests

1 similar comment
@bgorski
Copy link
Contributor Author

bgorski commented Mar 30, 2021

@magento run Functional Tests CE, Integration Tests

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests CE

@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 31, 2021
@m2-community-project m2-community-project bot removed this from Ready for Testing in Pull Requests Dashboard Mar 31, 2021
@engcom-Oscar engcom-Oscar added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Apr 1, 2021
@engcom-Oscar engcom-Oscar moved this from Ready for Testing to Extended Testing (optional) in High Priority Pull Requests Dashboard Apr 1, 2021
@engcom-Foxtrot engcom-Foxtrot self-assigned this Apr 1, 2021
@m2-community-project m2-community-project bot moved this from Extended Testing (optional) to Ready for Testing in High Priority Pull Requests Dashboard Apr 1, 2021
@engcom-Foxtrot engcom-Foxtrot moved this from Ready for Testing to Extended Testing (optional) in High Priority Pull Requests Dashboard Apr 1, 2021
@engcom-Foxtrot engcom-Foxtrot moved this from Extended Testing (optional) to Merge in Progress in High Priority Pull Requests Dashboard Apr 1, 2021
@gabrieldagama gabrieldagama mentioned this pull request Apr 11, 2021
Closed
5 tasks
@magento-engcom-team magento-engcom-team merged commit ad64536 into magento:2.4-develop Apr 11, 2021
magento-engcom-team pushed a commit that referenced this pull request Apr 11, 2021
@gabrieldagama
ENGCOM-8974: Added missing web-token/jwt-framework dependency to mage…
955ec18 
…nto/module-jwt-framework-adapter #32612
@m2-assistant
Copy link

m2-assistant bot commented Apr 11, 2021

Hi @bgorski, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@gabrieldagama gabrieldagama moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Foxtrot engcom-Foxtrot

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: JwtFrameworkAdapter Partner: MRM Commerce partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Type: Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing dependency in Magento/JwtFrameworkAdapter
6 participants
@bgorski @ihor-sviziev @magento-engcom-team @gabrieldagama @engcom-Foxtrot @engcom-Oscar